-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom-server-typescript example (see #3694) #3838
Conversation
I'm unable to use typescript syntax w/ any
|
@khuezy just edited the example, hope it works now, was a mistake on my side with |
@retrixe Thanks for getting this out! I had to escape the |
@khuezy Fixed all issues with linting and the escaping issue, 😅 everything works now, thanks for the feedback :) |
@retrixe I'm having trouble building. I had to change the build script to: w/o the |
Huh, I am unable to replicate on my side. I have switched the server to use |
in |
Just fixed that, but it still doesn't seem that that is the issue. |
@retrixe I finally figured out why my build was busted. For some reason, npm installed a really old version of Everything is 👍 now. Thanks for adding this customer server ts support. |
I just tried your example and it really helped me get a custom ts server! Two questions:
|
|
To summarise, I'll be happy to submit a PR that renames |
@kachkaev no problemo :) |
- Add "jsx": "preserve" to tsconfig.json - Rename lib to production-server to remove incompatibility with other examples Context: #3838 (comment) and below
One more tiny improvement: #3963 |
Requested in #2744 as well.