Fix SSR error handling in the global scope #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunoda
changed the title
arunoda
changed the title
timneutkens
approved these changes
Feb 24, 2018
timneutkens
reviewed
Feb 24, 2018
server/require.js
Outdated
| try { | ||
| return require(pagePath) | ||
| } catch (err) { | ||
| throw pageNotFoundError(page) | ||
| console.error(err) |
There was a problem hiding this comment.
This should be under the MODULE_NOT_FOUND check, because otherwise every page that doesn't exist will be shot into the console. This includes things like favicon.ico and robots.txt in development.
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3864