Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #40342

Merged
merged 9 commits into from Sep 8, 2022
Merged

docs: fix typos #40342

merged 9 commits into from Sep 8, 2022

Conversation

jasham
Copy link
Contributor

@jasham jasham commented Sep 8, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@balazsorban44 balazsorban44 changed the title Updatingfiletypoissues docs: fix typos Sep 8, 2022
docs/going-to-production.md Outdated Show resolved Hide resolved
docs/going-to-production.md Outdated Show resolved Hide resolved
docs/going-to-production.md Outdated Show resolved Hide resolved
docs/going-to-production.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
balazsorban44
balazsorban44 previously requested changes Sep 8, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some suggestions.

Generally next * commands should not require a definite article (the) in my opinion, even if a tool like Grammarly would suggest so. I think this happens because those tools cannot detect the meaning of the ` symbol, which changes the meaning slightly.

Accepted suggestions. Giving commit

Co-authored-by: Balázs Orbán <info@balazsorban.com>
@jasham
Copy link
Contributor Author

jasham commented Sep 8, 2022

Thanks! I left some suggestions.

Generally next * commands should not require a definite article (the) in my opinion, even if a tool like Grammarly would suggest so. I think this happens because those tools cannot detect the meaning of the ` symbol, which changes the meaning slightly.

Thanks. Corrected the suggested changes.

docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
mmaaaaz
mmaaaaz approved these changes Sep 8, 2022
ijjk
ijjk approved these changes Sep 8, 2022
@kodiakhq kodiakhq bot merged commit ea33b84 into vercel:canary Sep 8, 2022
79 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants