From d7b2605abea23d4078ddc6e7e84b38d0aee4ac30 Mon Sep 17 00:00:00 2001 From: rubytree33 <110690041+rubytree33@users.noreply.github.com> Date: Thu, 8 Sep 2022 21:30:56 -0400 Subject: [PATCH 1/3] fixed config-schema for esmExternals --- packages/next/server/config-schema.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/next/server/config-schema.ts b/packages/next/server/config-schema.ts index 984d0df6b77d75e..a7abb05943e6c2f 100644 --- a/packages/next/server/config-schema.ts +++ b/packages/next/server/config-schema.ts @@ -253,7 +253,10 @@ const configSchema = { type: 'boolean', }, esmExternals: { - type: 'boolean', + oneOf: [ + { type: 'boolean' }, + { type: 'string', pattern: 'loose' }, + ] as any, }, externalDir: { type: 'boolean', From 39cf9bfb845c0c72bccdfbfcebdfe9e927e30993 Mon Sep 17 00:00:00 2001 From: rubytree33 <110690041+rubytree33@users.noreply.github.com> Date: Thu, 8 Sep 2022 21:39:17 -0400 Subject: [PATCH 2/3] formatting --- packages/next/server/config-schema.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/next/server/config-schema.ts b/packages/next/server/config-schema.ts index a7abb05943e6c2f..4371a8b463670b7 100644 --- a/packages/next/server/config-schema.ts +++ b/packages/next/server/config-schema.ts @@ -254,8 +254,13 @@ const configSchema = { }, esmExternals: { oneOf: [ - { type: 'boolean' }, - { type: 'string', pattern: 'loose' }, + { + type: 'boolean', + }, + { + type: 'string', + pattern: 'loose', + }, ] as any, }, externalDir: { From 7faed2b372ca39fb275c3f3bd4e467c9895c80d9 Mon Sep 17 00:00:00 2001 From: rubytree33 <110690041+rubytree33@users.noreply.github.com> Date: Thu, 8 Sep 2022 21:51:15 -0400 Subject: [PATCH 3/3] esmExternals config schema minor idiomatic edit --- packages/next/server/config-schema.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/next/server/config-schema.ts b/packages/next/server/config-schema.ts index 4371a8b463670b7..6c06e28a48b3980 100644 --- a/packages/next/server/config-schema.ts +++ b/packages/next/server/config-schema.ts @@ -258,8 +258,7 @@ const configSchema = { type: 'boolean', }, { - type: 'string', - pattern: 'loose', + const: 'loose', }, ] as any, },