Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename allowDynamic to unstable_allowDynamic #40496

Merged
merged 1 commit into from Sep 12, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 12, 2022

Follow-up to #39539 as discussed this renames to unstable_ prefix initially while we test this out further.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk marked this pull request as ready for review September 12, 2022 22:32
@ijjk ijjk merged commit 8bf6a87 into vercel:canary Sep 12, 2022
79 of 80 checks passed
@ijjk ijjk deleted the update/rename-allow-dynamic branch September 12, 2022 22:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant