Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added with-jest-typescript example #4124

Merged
merged 4 commits into from
Apr 13, 2018
Merged

Added with-jest-typescript example #4124

merged 4 commits into from
Apr 13, 2018

Conversation

HarunD
Copy link
Contributor

@HarunD HarunD commented Apr 7, 2018

This example shows the setup and several Jest tests for a NextJS TypeScript app.

"version": "1.0.0",
"main": "index.js",
"license": "MIT",
"author": "Harun Djulic <harundjulic@gmail.com>",
Copy link
Member

@timneutkens timneutkens Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the package.json is the same as the other examples (same license, author, version etc)

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, only had a comment for the package.json

As per the comment, updated the package.json so the info is same as in other examples.
@timneutkens timneutkens merged commit c5c5564 into vercel:canary Apr 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants