Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build type error of page params #42019

Merged
merged 2 commits into from Oct 27, 2022
Merged

Fix build type error of page params #42019

merged 2 commits into from Oct 27, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 27, 2022

This PR temporarily fixes #41884 by loosing the type check rules. I will work on a follow up PR to type params better with tests.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

huozhi
huozhi previously approved these changes Oct 27, 2022
@huozhi huozhi self-requested a review Oct 27, 2022
Co-authored-by: Jiachi Liu <inbox@huozhi.im>
ijjk
ijjk approved these changes Oct 27, 2022
@ijjk
Copy link
Member

ijjk commented Oct 27, 2022

Failing test suites

Commit: f3b6ecd

pnpm testheadless test/unit/web-runtime/next-response.test.ts

  • can be cloned

Expand output

● can be cloned

TypeError: fetch failed

  at Object.processResponse (../evalmachine.<anonymous>:7941:27)
  at ../evalmachine.<anonymous>:8271:42

Read more about building and testing Next.js in contributing.md.

pnpm testheadless test/e2e/yarn-pnp/test/with-eslint.test.ts

  • yarn PnP > should compile and serve the index page correctly with-eslint
Expand output

● yarn PnP › should compile and serve the index page correctly with-eslint

thrown: "Exceeded timeout of 120000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  21 |     let next: NextInstance
  22 |
> 23 |     beforeAll(async () => {
     |     ^
  24 |       const srcDir = join(__dirname, '../../../../examples', example)
  25 |       const srcFiles = await fs.readdir(srcDir)
  26 |

  at runTests (e2e/yarn-pnp/test/utils.ts:23:5)
  at e2e/yarn-pnp/test/with-eslint.test.ts:4:11
  at Object.<anonymous> (e2e/yarn-pnp/test/with-eslint.test.ts:3:1)

● Test suite failed to run

next instance not destroyed before exiting, make sure to call .destroy() after the tests after finished

   98 |     if (nextInstance) {
   99 |       await nextInstance.destroy()
> 100 |       throw new Error(
      |             ^
  101 |         `next instance not destroyed before exiting, make sure to call .destroy() after the tests after finished`
  102 |       )
  103 |     }

  at lib/e2e-utils.ts:100:13

Read more about building and testing Next.js in contributing.md.

@shuding shuding merged commit 491a21b into canary Oct 27, 2022
69 of 71 checks passed
@shuding shuding deleted the shu/bv4u branch Oct 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next 13: Missing Types for generateStaticParams
4 participants