Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape HTML on "<Link> with <a> child" page #42114

Merged
merged 3 commits into from Oct 31, 2022
Merged

Escape HTML on "<Link> with <a> child" page #42114

merged 3 commits into from Oct 31, 2022

Conversation

DuncanOgle
Copy link
Contributor

@DuncanOgle DuncanOgle commented Oct 29, 2022

Non-escaped characters is leading this page to attempt to render the title as HTML tags. This change escapes those values so they may present correctly

https://nextjs.org/docs/messages/invalid-new-link-with-extra-anchor

Screenshot 2022-10-29 at 06 57 16

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Non-escaped characters is leading this page to attempt to render the title as HTML tags. This change escapes those values so they may present correctly
styfle
styfle approved these changes Oct 31, 2022
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 848bb3a into vercel:canary Oct 31, 2022
69 checks passed
@DuncanOgle DuncanOgle deleted the patch-1 branch October 31, 2022 17:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants