Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for @vercel/og API route #42258

Merged
merged 1 commit into from Oct 31, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 31, 2022

This ensures we don't have a fatal error when not necessary and ensures @vercel/og is working as expected.

x-ref: slack thread

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 31, 2022
@ijjk ijjk marked this pull request as ready for review Oct 31, 2022
styfle
styfle approved these changes Oct 31, 2022
@ijjk ijjk merged commit 50ced11 into vercel:canary Oct 31, 2022
68 checks passed
@ijjk ijjk deleted the update/tolerate-trace-copy branch Oct 31, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants