Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid breaking useRouter() type change #42430

Merged
merged 2 commits into from Nov 3, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 3, 2022

Since useRouter() can still be used in pages alone and should always be a valid instance we shouldn't change the default return type to avoid a breaking type change.

Fixes: #42409

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk merged commit 152f51c into vercel:canary Nov 3, 2022
16 of 19 checks passed
@ijjk ijjk deleted the fix/breaking-use-router-type branch November 3, 2022 18:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking type change on useRouter() in v13.0.2-canary.0
2 participants