Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static generation bail-out from usePathname #42440

Merged
merged 4 commits into from Nov 3, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 3, 2022

x-ref: slack thread

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

wyattjoh
wyattjoh previously approved these changes Nov 3, 2022
# Conflicts:
#	packages/next/client/components/navigation.ts
wyattjoh
wyattjoh previously approved these changes Nov 3, 2022
@ijjk
Copy link
Member Author

ijjk commented Nov 3, 2022

Failing test suites

Commit: 842cbf0

pnpm testheadless test/development/acceptance-app/ReactRefreshLogBox.test.ts

  • ReactRefreshLogBox app > logbox: can recover from a syntax error without losing state
Expand output

● ReactRefreshLogBox app › logbox: can recover from a syntax error without losing state

TIMED OUT: /Count: 1/

Count: 0

  532 |
  533 |   if (hardError) {
> 534 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  535 |   }
  536 |   return false
  537 | }

  at check (lib/next-test-utils.js:534:11)
  at Object.<anonymous> (development/acceptance-app/ReactRefreshLogBox.test.ts:107:5)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk merged commit eb0d9f5 into vercel:canary Nov 3, 2022
69 of 71 checks passed
@ijjk ijjk deleted the update/pathname-bailout branch November 3, 2022 21:57
@alvarlagerlof
Copy link

Thank you, this made my site much faster!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants