Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure RSC is detecting correctly during revalidate #42508

Merged
merged 1 commit into from Nov 4, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 4, 2022

Fixes: #42504

Patch tested against provided reproduction here https://portfolio-pcmtikvrv-ijjk-testing.vercel.app/

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 4, 2022
@ijjk ijjk merged commit 192dc6b into vercel:canary Nov 4, 2022
67 of 69 checks passed
@ijjk ijjk deleted the fix/revalidate-rsc branch November 4, 2022 23:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content-type sometimes octet-stream instead of tex/html causing browser to prompt to download the site
1 participant