Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that publicRuntimeConfig and serverRuntimeConfig do not work with Output File Tracing #43443

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

dtinth
Copy link
Contributor

@dtinth dtinth commented Nov 28, 2022

The Output File Tracing page mentioned that publicRuntimeConfig and serverRuntimeConfig are now legacy and does not work with Output File Tracing (they are inlined at build-time instead of being set at runtime, the way it is supposed to work).

image

However, the Runtime Config page itself does not mention this at all. This led me into a wrong path for a while.

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

…with Output File Tracing

This is mentioned in Output File Tracing page but not this page. This led me into a wrong path for a while.
styfle
styfle previously approved these changes Nov 30, 2022
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the note, thanks!

@styfle styfle merged commit 8603901 into vercel:canary Nov 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants