Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output: standalone test for app directory #43618

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 2, 2022

This test was ensuring app directory is working correctly with output: 'standalone'. Instead of removing config we should conditionally set it for the test.

Reverts #43607

x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832699
x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832421

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Dec 2, 2022
@ijjk ijjk marked this pull request as ready for review December 2, 2022 01:29
huozhi
huozhi previously approved these changes Dec 2, 2022
@ijjk ijjk merged commit 0590988 into canary Dec 2, 2022
@ijjk ijjk deleted the revert-43607-wyattjoh/app-dir-test-output branch December 2, 2022 02:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants