Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental for modularizeImports from docs and example #44311

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

chibicode
Copy link
Member

When modularizeImports was moved out of experiimental on this PR, docs and examples were not updated.

  • Update modularize-imports example by removing experimental from next.config.js, as it's currently failing when deployed
  • For docs: https://nextjs.org/docs/advanced-features/compiler#modularize-imports
    • Move Modularize Imports section outside of Experimental Features section
    • Remove experimental from code snippets
    • Added to version history, just like when SWC Minifier became stable.

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@@ -9,6 +9,7 @@ description: Learn about the Next.js Compiler, written in Rust, which transforms

| Version | Changes |
| --------- | ---------------------------------------------------------------------------------------------------------------------------------- |
| `v13.1.0` | Modularize Imports [stable](https://nextjs.org/blog/next-13-1#import-resolution-for-smaller-bundles). |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this change is necessary. I added it because there’s SWC Minifier stable 2 lines below, so I did something similar. But feel free to remove it if this isn’t necessary.

@kodiakhq kodiakhq bot merged commit f0aa10b into vercel:canary Dec 23, 2022
@chibicode chibicode deleted the fix-modularize-imports-docs-example branch December 23, 2022 20:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants