From c731c02c145b832acd79103f8737d69aa56f808e Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Mon, 10 Apr 2023 17:53:25 +0200 Subject: [PATCH] remove metadataBase warning --- .../src/lib/metadata/resolvers/resolve-url.ts | 6 ---- .../app/blog/opengraph-image.js | 23 -------------- .../app/blog/page.js | 9 ------ .../app/layout.js | 12 ------- .../index.test.ts | 31 ------------------- .../next.config.js | 3 -- 6 files changed, 84 deletions(-) delete mode 100644 test/e2e/app-dir/metadata-missing-metadata-base/app/blog/opengraph-image.js delete mode 100644 test/e2e/app-dir/metadata-missing-metadata-base/app/blog/page.js delete mode 100644 test/e2e/app-dir/metadata-missing-metadata-base/app/layout.js delete mode 100644 test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts delete mode 100644 test/e2e/app-dir/metadata-missing-metadata-base/next.config.js diff --git a/packages/next/src/lib/metadata/resolvers/resolve-url.ts b/packages/next/src/lib/metadata/resolvers/resolve-url.ts index cc8f6c19fa2e..7d59f5d553c5 100644 --- a/packages/next/src/lib/metadata/resolvers/resolve-url.ts +++ b/packages/next/src/lib/metadata/resolvers/resolve-url.ts @@ -1,5 +1,4 @@ import path from '../../../shared/lib/isomorphic/path' -import * as Log from '../../../build/output/log' function isStringOrURL(icon: any): icon is string | URL { return typeof icon === 'string' || icon instanceof URL @@ -26,11 +25,6 @@ function resolveUrl( if (!metadataBase) { metadataBase = new URL(`http://localhost:${process.env.PORT || 3000}`) - // Development mode warning, add new line prefix for worker output - console.log() - Log.warn( - `metadata.metadataBase is not set for resolving url "${url}", fallbacks to "${metadataBase.origin}". See https://beta.nextjs.org/docs/api-reference/metadata#metadatabase` - ) } // Handle relative or absolute paths diff --git a/test/e2e/app-dir/metadata-missing-metadata-base/app/blog/opengraph-image.js b/test/e2e/app-dir/metadata-missing-metadata-base/app/blog/opengraph-image.js deleted file mode 100644 index 06458b4ab507..000000000000 --- a/test/e2e/app-dir/metadata-missing-metadata-base/app/blog/opengraph-image.js +++ /dev/null @@ -1,23 +0,0 @@ -import { ImageResponse } from 'next/server' - -export const alt = 'Open Graph' - -export default function og() { - return new ImageResponse( - ( -
- Open Graph -
- ) - ) -} diff --git a/test/e2e/app-dir/metadata-missing-metadata-base/app/blog/page.js b/test/e2e/app-dir/metadata-missing-metadata-base/app/blog/page.js deleted file mode 100644 index eba737535cc7..000000000000 --- a/test/e2e/app-dir/metadata-missing-metadata-base/app/blog/page.js +++ /dev/null @@ -1,9 +0,0 @@ -import React from 'react' - -export default function Page() { - return <>hello index -} - -export const metadata = { - title: 'index page', -} diff --git a/test/e2e/app-dir/metadata-missing-metadata-base/app/layout.js b/test/e2e/app-dir/metadata-missing-metadata-base/app/layout.js deleted file mode 100644 index 28dde49b9408..000000000000 --- a/test/e2e/app-dir/metadata-missing-metadata-base/app/layout.js +++ /dev/null @@ -1,12 +0,0 @@ -export default function Layout({ children }) { - return ( - - - {children} - - ) -} - -export const metadata = { - title: 'Next.js App', -} diff --git a/test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts b/test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts deleted file mode 100644 index 49601f733ce4..000000000000 --- a/test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts +++ /dev/null @@ -1,31 +0,0 @@ -import { createNext, FileRef } from 'e2e-utils' -import { NextInstance } from 'test/lib/next-modes/base' -import { fetchViaHTTP } from 'next-test-utils' - -describe('app dir - metadata missing metadataBase', () => { - let next: NextInstance - - if ((global as any).isNextDeploy) { - return it('should skip for deploy', () => {}) - } - - beforeAll(async () => { - next = await createNext({ - skipStart: true, - files: new FileRef(__dirname), - }) - }) - afterAll(() => next.destroy()) - - it('should fallback to localhost if metadataBase is missing for absolute urls resolving', async () => { - await next.start() - await fetchViaHTTP(next.url, '/blog') - expect(next.cliOutput).toInclude( - 'metadata.metadataBase is not set for resolving url "/blog/opengraph-image?' - ) - expect(next.cliOutput).toInclude(', fallbacks to "http://localhost:') - expect(next.cliOutput).toInclude( - '. See https://beta.nextjs.org/docs/api-reference/metadata#metadatabase' - ) - }) -}) diff --git a/test/e2e/app-dir/metadata-missing-metadata-base/next.config.js b/test/e2e/app-dir/metadata-missing-metadata-base/next.config.js deleted file mode 100644 index 8e2a6c369174..000000000000 --- a/test/e2e/app-dir/metadata-missing-metadata-base/next.config.js +++ /dev/null @@ -1,3 +0,0 @@ -module.exports = { - experimental: { appDir: true }, -}