Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make .events work even when router is not initialized #4874

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Make .events work even when router is not initialized #4874

merged 2 commits into from
Jul 31, 2018

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jul 31, 2018 •
edited

Followup of #4863 (comment)

@timneutkens
Copy link
Member Author

timneutkens commented Jul 31, 2018 •
edited

@DullReferenceException could you review this PR? It's taking your comment and applying it differently 😄 I ran into the same issue when applying the new .events.on way on zeit.co.

DullReferenceException
DullReferenceException approved these changes Jul 31, 2018
View reviewed changes
Copy link

@DullReferenceException DullReferenceException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@timneutkens timneutkens merged commit 9240cf7 into vercel:canary Jul 31, 2018
@timneutkens timneutkens deleted the add/static-events-router branch July 31, 2018 19:04
@timneutkens
Copy link
Member Author

Thanks!

@DullReferenceException DullReferenceException mentioned this pull request Jul 31, 2018
Merged
@timneutkens timneutkens mentioned this pull request Jul 31, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DullReferenceException DullReferenceException DullReferenceException approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timneutkens @DullReferenceException