From 48f8a8f103cc61e91bbb8e1f07d30032b5cbe19f Mon Sep 17 00:00:00 2001 From: Emilio Schaedler Heinzmann <103655828+emiliosheinz@users.noreply.github.com> Date: Sun, 27 Aug 2023 15:19:28 -0300 Subject: [PATCH 1/2] docs: adds optional chaining to parent call on the generateMetadata example --- .../06-optimizing/04-metadata.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx b/docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx index ec01d31b08889..c263dddca7fe8 100644 --- a/docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx +++ b/docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx @@ -66,7 +66,7 @@ export async function generateMetadata( const product = await fetch(`https://.../${id}`).then((res) => res.json()) // optionally access and extend (rather than replace) parent metadata - const previousImages = (await parent).openGraph?.images || [] + const previousImages = (await parent)?.openGraph?.images || [] return { title: product.title, @@ -88,7 +88,7 @@ export async function generateMetadata({ params, searchParams }, parent) { const product = await fetch(`https://.../${id}`).then((res) => res.json()) // optionally access and extend (rather than replace) parent metadata - const previousImages = (await parent).openGraph?.images || [] + const previousImages = (await parent)?.openGraph?.images || [] return { title: product.title, From 30e75b55f788ecfcaf3d1d499c37fb4bdeeb4fc2 Mon Sep 17 00:00:00 2001 From: Emilio Schaedler Heinzmann <103655828+emiliosheinz@users.noreply.github.com> Date: Sun, 27 Aug 2023 17:12:43 -0300 Subject: [PATCH 2/2] docs: updates generateMetadata function definition --- .../06-optimizing/04-metadata.mdx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx b/docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx index c263dddca7fe8..61bf861fb90a3 100644 --- a/docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx +++ b/docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx @@ -57,7 +57,7 @@ type Props = { export async function generateMetadata( { params, searchParams }: Props, - parent?: ResolvingMetadata + parent: ResolvingMetadata ): Promise { // read route params const id = params.id @@ -66,7 +66,7 @@ export async function generateMetadata( const product = await fetch(`https://.../${id}`).then((res) => res.json()) // optionally access and extend (rather than replace) parent metadata - const previousImages = (await parent)?.openGraph?.images || [] + const previousImages = (await parent).openGraph?.images || [] return { title: product.title, @@ -88,7 +88,7 @@ export async function generateMetadata({ params, searchParams }, parent) { const product = await fetch(`https://.../${id}`).then((res) => res.json()) // optionally access and extend (rather than replace) parent metadata - const previousImages = (await parent)?.openGraph?.images || [] + const previousImages = (await parent).openGraph?.images || [] return { title: product.title,