From 63906b258c729e03137836f36c59edb7d902b0a0 Mon Sep 17 00:00:00 2001 From: Jan Amann Date: Tue, 28 Nov 2023 11:36:52 +0100 Subject: [PATCH] fix: Put back type for `NavigateOptions.scroll` It seems like in https://github.com/vercel/next.js/commit/24b2ff16abaa973d695247a9c1ac4e229640d4ca#diff-421107ce62efb02560358d25c5eb086d5d82d2ad1c7c4929ebfb768c2ea1c973 `forceOptimisticNavigation` was removed, but the `@internal` flag that was originally assigned to this option remained in place. Due to this, it seems like `scroll` is missing in the built types (see [`app-router-context.shared-runtime.d.ts` in the latest canary](https://unpkg.com/browse/next@14.0.4-canary.18/dist/shared/lib/app-router-context.shared-runtime.d.ts)). --- .../next/src/shared/lib/app-router-context.shared-runtime.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/next/src/shared/lib/app-router-context.shared-runtime.ts b/packages/next/src/shared/lib/app-router-context.shared-runtime.ts index 250151cbb7a5..6b6ee05e900c 100644 --- a/packages/next/src/shared/lib/app-router-context.shared-runtime.ts +++ b/packages/next/src/shared/lib/app-router-context.shared-runtime.ts @@ -68,7 +68,6 @@ export type CacheNode = } export interface NavigateOptions { - /** @internal */ scroll?: boolean }