CNA: exclude ts(js)conf.json as well as .git folder#61412
Merged
styfle merged 2 commits intovercel:canaryfrom Jan 31, 2024
chrisweb:canary
Merged
CNA: exclude ts(js)conf.json as well as .git folder#61412styfle merged 2 commits intovercel:canaryfrom chrisweb:canary
styfle merged 2 commits intovercel:canaryfrom
chrisweb:canary
Conversation
Member
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
On windows the .git/* files are read only, when the CNA "import path" script attempts to open one of the .git/* files
Why?
attempting to open any of the .git/* files results in an error thrown by CNA and CNA exists, hence not finishing the setup of a new project
How?
My suggested fix uses the fast-glob ignore option to exclude the .git folder, I also moved the the ts(js)config.json exclusion into the ignore (was an "if" before)
Fixes #61411 (more context in the discussion #61261)