-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add native css nesting support #62644
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Failing test suitesCommit: 7fde8fa
Expand output● app dir - metadata › react cache › should have same title and page value when navigating
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for middleware.jsDiff too large to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a
thanks for merging |
Woo! |
today ~83% of all browsers support css nesting: https://caniuse.com/css-nesting
https://caniuse.com/css-nesting
https://developer.mozilla.org/en-US/docs/Web/CSS/Nesting_selector
therefore this pr upgrades postcss-modules-local-by-default which fixes a bug in css-modules/postcss-modules-local-by-default#64)
.foo { &:hover { a_value: some-value; } }
is pure.foo { html &:hover { a_value: some-value; } }
is pure.foo { &:global(.bar) { a_value: some-value; } }
is pure:global(.foo) { &:hover { a_value: some-value; } }
is not pureupgrading the package will allow using css nestings with or without postcss compilation
it fixes the following error:
Fixes #55053
Fixes #33734
Fixes #10475