docs(cacheTag): remove unused cacheLife import and add missing switcher#72217
Merged
Conversation
…tcher` Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
devjiwonchoi
approved these changes
Nov 2, 2024
Member
|
Thank you for the PR! |
Contributor
Author
|
@devjiwonchoi Thanks for reviewing the PR! If you have a few spare minutes, would you like to take a look at the other two similar PRs #72215 and #72216 as well? |
Member
|
Sure! Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues on the cacheTag documentation page:
Remove the unused
unstable_cacheLifeimport in the TypeScript codeblock of Creating tags from external data section:Missing
switcherfor TS codeblock in Creating tags from external data and Invalidating tagged cache sections. We already have the corresponding JS codeblock in the Markdown.