[dev-overlay] Implement notch design by raunofreiberg · Pull Request #75679 · vercel/next.js

raunofreiberg · 2025-02-05T09:16:22Z

This PR implements a new design for the experimental Next.js Error Overlay:

Border-less body design
Notch cut-out for the navigation and version info

Closes NDX-782
Closes NDX-781

…rlay-polish

ijjk · 2025-02-05T09:20:36Z

Tests Passed

ijjk · 2025-02-05T09:23:54Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
buildDuration	16.3s	14.6s	N/A
buildDurationCached	13.9s	11.7s	N/A
nodeModulesSize	392 MB	393 MB	⚠️ +34.5 kB
nextStartRea..uration (ms)	387ms	410ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
5306-HASH.js gzip	54.2 kB	54.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	✓
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
index.html gzip	523 B	524 B	N/A
link.html gzip	538 B	539 B	N/A
withRouter.html gzip	519 B	520 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
middleware-b..fest.js gzip	673 B	672 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
app-page-exp...dev.js gzip	394 kB	394 kB	⚠️ +507 B
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	381 kB	381 kB	⚠️ +541 B
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.5 kB	60.5 kB	✓
Overall change	1.67 MB	1.67 MB	⚠️ +1.05 kB

build cache

	vercel/next.js canary	vercel/next.js rf/overlay-cleanup	Change
0.pack gzip	2.1 MB	2.1 MB	N/A
index.pack gzip	75.7 kB	75 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: c17d634

…eanup

raunofreiberg · 2025-02-10T15:19:38Z

-    &[data-animate='true'] {
-      filter: blur(4px);
-      animation: fadeIn 250ms var(--timing-swift) forwards
-        calc(var(--index) * 25ms);
-    }
-


This was dropping frames on Safari with large lists, lets kill

raunofreiberg · 2025-02-10T15:26:19Z

-      dialog.style.height = `${initialDialogHeight.current + ignoreListHeight}px`
-      setIsIgnoreListOpen(!isIgnoreListOpen)


This just simplifies the logic, we don't need to add the height manually, parent ResizeObserver will do its job

raunofreiberg · 2025-02-10T15:26:51Z


  return (
-    <div data-nextjs-terminal>
+    <div data-nextjs-codeframe>


Nothing crazy here, just reusing styles from the code frame component

raunofreiberg · 2025-02-10T15:27:24Z

-  if (!versionInfo) return null
  const { staleness } = versionInfo
  let { text, indicatorClass, title } = getStaleness(versionInfo)

-  if (!text) return null


This component should just naively render whatever it could, we check for null in the parent

raunofreiberg · 2025-02-10T15:35:49Z


    display: flex;
-    flex-direction: column;
+    flex-direction: column-reverse;


Reversed so we can leverage natural DOM order to keep the notch navigation a layer above the dialog contents on the Z-axis without explicitly declaring z-index

devjiwonchoi · 2025-02-10T17:04:44Z

Why are these removed?

Following up of #75679 ### Why? Clicking the navigation escapes the overlay. It is because the navigation component is outside of the dialog component. #### Before https://github.com/user-attachments/assets/e7c63261-c44b-4af7-936d-1750dff07527 #### After https://github.com/user-attachments/assets/979421fa-fb71-481d-bd58-6703298db28b ### How? Since we already have logic to prevent closing overlay when clicked outside the component for dev indicator, add the header to this CSS selectors list as well.

raunofreiberg added 30 commits January 28, 2025 13:29

overlay wip

e76f4c0

Merge branch 'canary' of github.com:vercel/next.js into rf/errors-ove…

5aad57e

…rlay-polish

wip

c1e608a

many fixes

f3099b0

fix animation height

1ffd693

cleanup

fd20ef8

align turbo border

ed8066a

Update call-stack-frame.tsx

e5d531d

Remove svg

12fad68

add app img

08e5e85

Update next-logo.tsx

8e83f15

add animation

d55a2ff

fix Escape

95f41b0

Update styles.ts

ca5c636

Update dialog.tsx

0ba2599

Update error-feedback.tsx

213f534

Fix test

8765470

oops

624d28c

test

f98dc71

call stack animate

0ad9f46

Fix Safari

e2ef6db

Unify terminal and code frame styles

9ec2d75

Cleanup dialog

2515df7

Colored icons

f9fa928

Remove unnecessary icons

de420f0

Remove clipping

2f8b959

Only return focus to trigger when focus was previously inside menu

704a222

Revert icons to no color

dd2302d

add weight 500 geist mono

56b9950

Rewrite to use dialogResizerRef instead of relying on DOM

6b648a1

ijjk added the type: next label Feb 5, 2025

raunofreiberg added 4 commits February 5, 2025 11:54

simplify animation

4e41c48

cleanup

710eef4

Revert lint config

fdfffb2

Merge branch 'canary' of github.com:vercel/next.js into rf/overlay-cl…

29abcf3

…eanup

raunofreiberg changed the title ~~[Error Overlay] TBD~~ [Error Overlay] New design Feb 10, 2025

raunofreiberg commented Feb 10, 2025

View reviewed changes

oops

cb969a1

raunofreiberg commented Feb 10, 2025

View reviewed changes

raunofreiberg marked this pull request as ready for review February 10, 2025 15:27

raunofreiberg requested a review from devjiwonchoi February 10, 2025 15:27

raunofreiberg commented Feb 10, 2025

View reviewed changes

devjiwonchoi reviewed Feb 10, 2025

View reviewed changes

devjiwonchoi added 2 commits February 11, 2025 02:06

rename as error-overlay-nav

26b036e

fix lint

bde28e2

devjiwonchoi force-pushed the rf/overlay-cleanup branch from bcdfe88 to bde28e2 Compare February 10, 2025 17:09

fix test util

c17d634

ijjk added the tests label Feb 10, 2025

devjiwonchoi approved these changes Feb 10, 2025

View reviewed changes

devjiwonchoi merged commit f859963 into canary Feb 10, 2025

devjiwonchoi deleted the rf/overlay-cleanup branch February 10, 2025 18:14

devjiwonchoi mentioned this pull request Feb 10, 2025

[dev-overlay] HOTFIX: clicking nav escapes the overlay #75876

Merged

github-actions Bot added the locked label Feb 25, 2025

github-actions Bot locked as resolved and limited conversation to collaborators Feb 25, 2025

raunofreiberg changed the title ~~[Error Overlay] New design~~ [dev-overlay] Implement notch design Jun 25, 2025

Navigation Menu

Uh oh!

[dev-overlay] Implement notch design - #75679

[dev-overlay] Implement notch design#75679
devjiwonchoi merged 52 commits into
canaryfrom
rf/overlay-cleanup

raunofreiberg commented Feb 5, 2025 •

edited

Loading

Uh oh!

ijjk commented Feb 5, 2025 •

edited

Loading

Uh oh!

ijjk commented Feb 5, 2025 •

edited

Loading

Uh oh!

raunofreiberg Feb 10, 2025

Uh oh!

raunofreiberg Feb 10, 2025

Uh oh!

raunofreiberg Feb 10, 2025

Uh oh!

raunofreiberg Feb 10, 2025 •

edited

Loading

Uh oh!

raunofreiberg Feb 10, 2025

Uh oh!

devjiwonchoi Feb 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		dialog.style.height = `${initialDialogHeight.current + ignoreListHeight}px`
		setIsIgnoreListOpen(!isIgnoreListOpen)

Uh oh!

Conversation

raunofreiberg commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijjk commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests Passed

Uh oh!

ijjk commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats from current PR

Uh oh!

raunofreiberg Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

raunofreiberg Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

raunofreiberg Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

raunofreiberg Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raunofreiberg Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

devjiwonchoi Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raunofreiberg commented Feb 5, 2025 •

edited

Loading

ijjk commented Feb 5, 2025 •

edited

Loading

ijjk commented Feb 5, 2025 •

edited

Loading

raunofreiberg Feb 10, 2025 •

edited

Loading