Keep all fields with one single key #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 73dc35b:
|
huozhi
approved these changes
Apr 4, 2022
Merged
himanshiLt
pushed a commit
to himanshiLt/swr
that referenced
this pull request
Jun 10, 2022
* store all data fields using one single key * fix tests * fix bugs and tests * fix lint error * refactor code * get rid of $ and $ * simplify serialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to address #1723. This is a potential breaking change for those who directly access to the cache (e.g. doing
cache.set(key, value), or initializing the cache with prefilled data).Todos:
$inf$,$ctx$and$len$keys in SWRInfinite as well.Figure out a good solution for the "prefilling data into cache" scenarios.