Improved React 18 support #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* type: extends useConfig cache interface (vercel#1938) * remove mount check for react18 (vercel#1927) reactwg/react-18#82 related pr vercel#787 vercel#433 * lint: dont check unused vars with underscore prefix (vercel#1939) * test: upgrade to jest 28 (vercel#1942) * Upgrade to jest 28 * Upgrade to jest 28 * feat: useSyncExternalStoreWithSelector * refactor: remove stateUpdate and boardcast state update should be handled by uSESW * type: fix test type error * remove pnpm.lock * fix: import cjs for codesanbox * refactor: add selector * refactor: add cachestate interface and try fix custom cache * fix: custom cache init * refactor: remove useless flag * chore: codesanbox ci * refactor: remove force render in infinite * build: add _internal * chore: mark warning test * fix: dts generation * codesanbox ci * chore: rename swr folder to core Co-authored-by: Jiachi Liu <inbox@huozhi.im>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 42dc3a1:
|
shuding
approved these changes
May 13, 2022
chibicode
reviewed
May 13, 2022
Comment on lines
+274
to
+279
| export interface CacheValue<Data = any, Error = any> { | ||
| data?: Data | ||
| error?: Error | ||
| isValidating?: boolean | ||
| isLoading?: boolean | ||
| } |
There was a problem hiding this comment.
CacheValue is identical to State (see https://github.com/vercel/swr/pull/1961/files#r872242431)
Lines 177 to 182 in 9a0328f
There was a problem hiding this comment.
These two types should be merged
| set(key: Key, value: State<Data, Error>): void | ||
| export interface Cache<Data = any> { | ||
| get(key: Key): CacheValue<Data> | undefined | ||
| set(key: Key, value: Data): void |
There was a problem hiding this comment.
The type of set was updated in https://github.com/vercel/swr/pull/1961/files#r872245634 - seems like a regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the SWR core with
useSyncExternalStoreandstartTransition, also moved utils into a shared sub-import.