Wrap side effects to fix new warnings in React 16.13 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolefty
commented
Mar 25, 2020
| revalidate: swr.revalidate, | ||
| isValidating: swr.isValidating, | ||
| mutate: swr.mutate | ||
| // hoist side effects: setPageSWRs and setPageOffsets -- https://reactjs.org/blog/2020/02/26/react-v16.13.0.html#warnings-for-some-updates-during-render |
There was a problem hiding this comment.
Suggested change
| // hoist side effects: setPageSWRs and setPageOffsets -- https://reactjs.org/blog/2020/02/26/react-v16.13.0.html#warnings-for-some-updates-during-render |
Okay to delete this comment?
There was a problem hiding this comment.
I think it's better to keep it! :)
neolefty
changed the title
neolefty
commented
Mar 25, 2020
| isValidating: swr.isValidating, | ||
| mutate: swr.mutate | ||
| // hoist side effects: setPageSWRs and setPageOffsets -- https://reactjs.org/blog/2020/02/26/react-v16.13.0.html#warnings-for-some-updates-during-render | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Another way to hoist is useEffect()s, possibly with dependency arrays to take the place of the if clauses below.
neolefty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #290 "Warning in React 16.13.0"
New warnings in React 16.13 — especially triggering
setState()from another component.This change:
setTimeout()around twosetState()calls inuseSWRPages(). There's a comment in it that we can probably delete.setState(). But that's actually the point of the new warnings, I think.