Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation improvements #321

Merged
merged 3 commits into from Mar 31, 2020
Merged

Minor documentation improvements #321

merged 3 commits into from Mar 31, 2020

Conversation

akx
Copy link
Contributor

@akx akx commented Mar 30, 2020

I found the docs for mutate a little lacking, so here's a couple small improvements.

Closes #322.

@shuding
Copy link
Member

shuding commented Mar 30, 2020

Thank you @akx!

@jan-paulus
Copy link

jan-paulus commented Mar 30, 2020

Would be good to also update the usage examples within the README.md.

Edit: I'll open a PR for that

@shuding
Copy link
Member

shuding commented Mar 30, 2020

Oops we have some conflicts, could you help fix them? @akx

@jan-paulus
Copy link

Created a new PR including the example update.

See: #322

@akx
Copy link
Contributor Author

akx commented Mar 31, 2020

@quietshu Rebased (with compare(a, b) now also having a signature).

Also added @jan-paulus' example from #322 (with proper Git commit authorship naturally).

@shuding
Copy link
Member

shuding commented Mar 31, 2020

Thank you @akx @jan-paulus !

@shuding shuding merged commit 9525622 into vercel:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants