Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NS Domain Record not supported #43

Closed
DaleLJefferson opened this issue Jun 7, 2022 · 5 comments · Fixed by #45
Closed

NS Domain Record not supported #43

DaleLJefferson opened this issue Jun 7, 2022 · 5 comments · Fixed by #45

Comments

@DaleLJefferson
Copy link

I was able to import a NS record but when I try to run plan I get the following error.

Item must be one of MX SRV TXT A AAAA ALIAS CAA CNAME, got: NS

resource "vercel_dns_record" "domainkey" {
  domain  = "b2b.store"
  name    = "e7a7dafdhajdhd"
  type    = "NS"
  ttl     = 60
  value   = "ns.vali.email."
  team_id = "team_d7ahdhah"
}
@dglsparsons
Copy link
Collaborator

Hey, thanks for raising this. I don't think I added support for NS records yet. I'll have a look soon though, as I think it should be fairly simple to add.

@DaleLJefferson
Copy link
Author

Thanks for the prompt reply, so far the Vercel Terraform integration is working really well we have it setup with Project, DNS and domains.

I guess it might just be this line? https://github.com/vercel/terraform-provider-vercel/blob/main/vercel/resource_dns_record.go#L54

@dglsparsons
Copy link
Collaborator

I'm super happy that it's working out really nicely for you. That is indeed the offending line, although tests/etc. also required. I'll start working on a fix now :)

@dglsparsons
Copy link
Collaborator

This is released in v0.6.0. Enjoy! 🎊

@DaleLJefferson
Copy link
Author

I've just tested it and I can confirm it's fixed. Nice work, very impressive turnaround. 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants