From 306f130150ce4cf22f97ddfa6d25533dffaca3f2 Mon Sep 17 00:00:00 2001
From: "Mitch (a.k.a Voz)" <mitch.vostrez@vercel.com>
Date: Tue, 20 Feb 2024 13:18:45 -0600
Subject: [PATCH] chore: Clippy strikes again (#7438)

### Description
Clippy be clippin


Closes TURBO-2399
---
 crates/turbopack-ecmascript/src/tree_shake/tests.rs | 2 +-
 crates/turbopack/tests/node-file-trace.rs           | 2 +-
 crates/turborepo-paths/src/absolute_system_path.rs  | 3 +--
 crates/turborepo-wax/src/walk/mod.rs                | 3 +--
 packages/turbo-repository/rust/src/lib.rs           | 2 +-
 5 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/crates/turbopack-ecmascript/src/tree_shake/tests.rs b/crates/turbopack-ecmascript/src/tree_shake/tests.rs
index 0ac58b17f910a..443016552df60 100644
--- a/crates/turbopack-ecmascript/src/tree_shake/tests.rs
+++ b/crates/turbopack-ecmascript/src/tree_shake/tests.rs
@@ -283,7 +283,7 @@ fn print<N: swc_core::ecma::codegen::Node>(cm: &Arc<SourceMap>, nodes: &[&N]) ->
 fn render_graph(item_ids: &[ItemId], g: &mut DepGraph) -> String {
     let mut mermaid = String::from("graph TD\n");
 
-    for (_, id) in item_ids.iter().enumerate() {
+    for id in item_ids.iter() {
         let i = g.g.node(id);
 
         writeln!(mermaid, "    Item{};", i + 1).unwrap();
diff --git a/crates/turbopack/tests/node-file-trace.rs b/crates/turbopack/tests/node-file-trace.rs
index 9c050adff889e..7335630410ba6 100644
--- a/crates/turbopack/tests/node-file-trace.rs
+++ b/crates/turbopack/tests/node-file-trace.rs
@@ -740,7 +740,7 @@ impl std::str::FromStr for CaseInput {
 async fn print_graph(asset: Vc<Box<dyn OutputAsset>>) -> Result<()> {
     let mut visited = HashSet::new();
     let mut queue = Vec::new();
-    queue.push((0, asset.clone()));
+    queue.push((0, asset));
     while let Some((depth, asset)) = queue.pop() {
         let references = asset.references().await?;
         let mut indent = String::new();
diff --git a/crates/turborepo-paths/src/absolute_system_path.rs b/crates/turborepo-paths/src/absolute_system_path.rs
index e9af365fdad16..840f106d191f1 100644
--- a/crates/turborepo-paths/src/absolute_system_path.rs
+++ b/crates/turborepo-paths/src/absolute_system_path.rs
@@ -510,7 +510,6 @@ impl<'a> TryFrom<&'a Path> for &'a AbsoluteSystemPath {
 #[cfg(test)]
 mod tests {
     use anyhow::Result;
-    use tempdir::TempDir;
     use test_case::test_case;
 
     use super::*;
@@ -606,7 +605,7 @@ mod tests {
             mode: Option<Permissions>,
             expected: Permissions,
         ) -> Result<()> {
-            let test_dir = TempDir::new("mkdir-all")?;
+            let test_dir = tempdir::TempDir::new("mkdir-all")?;
 
             let test_path = test_dir.path().join("foo");
 
diff --git a/crates/turborepo-wax/src/walk/mod.rs b/crates/turborepo-wax/src/walk/mod.rs
index 3ee4611685928..45c94e9295c1a 100644
--- a/crates/turborepo-wax/src/walk/mod.rs
+++ b/crates/turborepo-wax/src/walk/mod.rs
@@ -1084,7 +1084,6 @@ mod tests {
 
     use build_fs_tree::{dir, file, Build, FileSystemTree};
     use path_slash::PathBufExt;
-    use regex::Regex;
     use tempfile::{self, TempDir};
 
     use crate::{
@@ -1312,7 +1311,7 @@ mod tests {
         // it a valid glob, we must
         #[cfg(windows)]
         let slash_path = {
-            let regex = Regex::new("([A-Z]):").unwrap();
+            let regex = regex::Regex::new("([A-Z]):").unwrap();
             regex.replace(&slash_path, "$1\\:")
         };
 
diff --git a/packages/turbo-repository/rust/src/lib.rs b/packages/turbo-repository/rust/src/lib.rs
index f57a7ce44191e..cd4cc2ad94c69 100644
--- a/packages/turbo-repository/rust/src/lib.rs
+++ b/packages/turbo-repository/rust/src/lib.rs
@@ -183,7 +183,7 @@ impl Workspace {
             })
             .map(|p| {
                 let package_path = workspace_root.resolve(&p.path);
-                Package::new(p.name.to_string(), &workspace_root, &package_path)
+                Package::new(p.name.to_string(), workspace_root, &package_path)
             })
             .collect();