From f20dd903fc3770341153c916193a146b2dc80c66 Mon Sep 17 00:00:00 2001 From: Chris Olszewski Date: Tue, 26 Mar 2024 14:16:05 -0700 Subject: [PATCH] fix(ui): account for border when reserving size for logs (#7846) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### Description 🤦 I forgot to account for the border that we're adding to task logs. I believe this will address the odd output seen in [this comment](https://github.com/vercel/turbo/issues/7843#issuecomment-2021162101) ### Testing Instructions Before Screenshot 2024-03-26 at 1 32 41 PM After Screenshot 2024-03-26 at 1 31 24 PM Closes TURBO-2701 --- crates/turborepo-ui/src/tui/pane.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/turborepo-ui/src/tui/pane.rs b/crates/turborepo-ui/src/tui/pane.rs index fd9eb1cbdeb0a..2a0523ae82d62 100644 --- a/crates/turborepo-ui/src/tui/pane.rs +++ b/crates/turborepo-ui/src/tui/pane.rs @@ -203,7 +203,9 @@ impl TerminalOutput { .title(title.as_str()) .title(Title::from(title.as_str()).position(Position::Bottom)); let term = PseudoTerminal::new(&screen).cursor(cursor).block(block); - terminal.insert_before(rows as u16, |buf| term.render(buf.area, buf))?; + terminal.insert_before((rows as u16).saturating_add(2), |buf| { + term.render(buf.area, buf) + })?; self.has_been_persisted = true; Ok(())