Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to turbo.json #218

Closed
wants to merge 3 commits into from
Closed

Move to turbo.json #218

wants to merge 3 commits into from

Conversation

jaredpalmer
Copy link
Contributor

@jaredpalmer jaredpalmer commented Dec 12, 2021

Close #217

  • Move config
  • Write code-mod script
  • Update docs

@vercel
Copy link

vercel bot commented Dec 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/2taK9KreSB3WmYHxVuXd6ECLVXsx
✅ Preview: https://turbo-site-git-feat-turbo-json.vercel.sh

@jaredpalmer jaredpalmer changed the title Move to turbo.json Move to turbo.json Dec 12, 2021
@jaredpalmer jaredpalmer self-assigned this Dec 12, 2021
@jaredpalmer jaredpalmer mentioned this pull request Dec 14, 2021
@weyert
Copy link
Contributor

weyert commented Dec 21, 2021

Pretty excited about this as this PR suggests Turborepo will support taking environment variables into account for the hashes.

Also like having turbo.json in a separate file as stops package.json from cluttering up

@jlorezz
Copy link

jlorezz commented Dec 21, 2021

Pretty excited about this as this PR suggests Turborepo will support taking environment variables into account for the hashes.

Also like having turbo.json in a separate file as stops package.json from cluttering up

I agree! package.json is pretty hard to keep track of with all of that configuration.

@jaredpalmer
Copy link
Contributor Author

Superseded by #606

sokra pushed a commit that referenced this pull request Oct 25, 2022
Split from #209

This lets any non-`#[turbo_tasks::value]` struct be debug-formatted properly when inside another `#[turbo_tasks::value]` struct.

e.g.

```rust
#[turbo_tasks::value]
struct Value1 {
  value2: Value2,
}


#[derive(TraceRawVcs, Serialize, Debug, Deserialize, PartialEq, Eq)
struct Value2 {
  value3: Value3Vc
}

#[turbo_tasks::value]
struct Value3 {
  str: StringVc
}
```

Prints:

```rust
Value1 {
    value2: Value2 {
        value3: Value3Vc {
            node: TaskCell(
                TaskId {
                    id: 58,
                },
                0,
            ),
        },
    },
}
```

Replacing the `Debug` derive with `ValueDebugFormat` for `Value2` prints:

```rust
Value1 {
    value2: Value2 {
        value3: Value3 {
          str: "hello!"
        },
    },
}
```
sokra pushed a commit that referenced this pull request Oct 25, 2022
@ForsakenHarmony ForsakenHarmony deleted the feat/turbo-json branch January 9, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move config to turbo.json
3 participants