New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] support middleware-manifest v2 #8319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing the below error while testing, we may want to clean up the error as it's not exactly clear which route was incorrect and the expected values.
21:55:12.935 | Created all serverless functions in: 46.001ms
21:55:12.967 | Collected static files (public/, static/, .next/static): 2.554ms
21:55:13.161 | Build Completed in /vercel/output [24s]
21:55:13.646 | Error: Mapping middleware not found. Maybe you provided a wrong middlewarePath? Available paths: middleware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides JJ's request for better error handling, no extra requests.
The error @ijjk mentioned should have already been fixed by https://github.com/vercel/api/pull/13624 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look good, will hold off on approving until the e2e deploy tests are passing on the Next.js PR though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related Issues
As the title, support a new version of middleware-manifest of next.js that is going to be added in vercel/next.js#39257
馃搵 Checklist
Tests
yarn test-unit
Code Review