-
Notifications
You must be signed in to change notification settings - Fork 129
[world-local] Fix long-running steps to not time out after 5 minutes #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 22c8d23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Just ran the test again on your latest changes #137 (comment) This resolves issue #137 |
| catalog: | ||
| '@biomejs/biome': ^2.2.5 | ||
| '@types/node': 24.6.2 | ||
| '@types/node': 22.19.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agent from undici was giving a type error when passing to fetch() when using Node v24.
In general this is a good change because we should be using types from the lowest supported version ideally, so that we are not relying on types that do not exist in older versions of Node.
VaguelySerious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| import { JsonTransport } from '@vercel/queue'; | ||
| import { MessageId, type Queue, ValidQueueName } from '@workflow/world'; | ||
| import { monotonicFactory } from 'ulid'; | ||
| import { Agent } from 'undici'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little sad we need a 1.5MB package just to set a timeout, but I also don't see a better workaround here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Pretty lame that Node doesn't export this itself.

Fixes #137.