Skip to content

Conversation

@TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Nov 3, 2025

Fixes #137.

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

🦋 Changeset detected

Latest commit: 22c8d23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@workflow/core Patch
@workflow/world-local Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
workflow Patch
@workflow/world-postgres Patch
@workflow/world-testing Patch
@workflow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Comment Nov 3, 2025 5:49pm
example-nextjs-workflow-webpack Ready Ready Preview Comment Nov 3, 2025 5:49pm
example-workflow Ready Ready Preview Comment Nov 3, 2025 5:49pm
workbench-nitro-workflow Ready Ready Preview Comment Nov 3, 2025 5:49pm
workbench-sveltekit-workflow Error Error Nov 3, 2025 5:49pm
workbench-vite-workflow Error Error Nov 3, 2025 5:49pm
workflow-docs Ready Ready Preview Comment Nov 3, 2025 5:49pm

@socket-security
Copy link

socket-security bot commented Nov 3, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​undici@​6.22.09910010094100
Addednpm/​@​types/​node@​22.19.0100100100100100

View full report

@eersnington
Copy link
Contributor

Just ran the test again on your latest changes #137 (comment)

This resolves issue #137

catalog:
'@biomejs/biome': ^2.2.5
'@types/node': 24.6.2
'@types/node': 22.19.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:fyi: This downgrade was because the Agent from undici was giving a type error when passing to fetch() when using Node v24.

In general this is a good change because we should be using types from the lowest supported version ideally, so that we are not relying on types that do not exist in older versions of Node.

Copy link
Member

@VaguelySerious VaguelySerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import { JsonTransport } from '@vercel/queue';
import { MessageId, type Queue, ValidQueueName } from '@workflow/world';
import { monotonicFactory } from 'ulid';
import { Agent } from 'undici';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little sad we need a 1.5MB package just to set a timeout, but I also don't see a better workaround here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Pretty lame that Node doesn't export this itself.

@TooTallNate TooTallNate merged commit 10309c3 into main Nov 3, 2025
26 of 28 checks passed
@TooTallNate TooTallNate deleted the fix/world-local-fetch-5m-timeout branch November 3, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long-running local-world steps fail after ~5 minutes

4 participants