Skip to content

fix: @vercel/nft parsing proc file paths in sveltekit adapter #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adriandlam merged 3 commits into from
Dec 1, 2025
Merged

fix: @vercel/nft parsing proc file paths in sveltekit adapter #473

adriandlam merged 3 commits into from
Dec 1, 2025
+13 −2

Conversation

@adriandlam
Copy link
Member

@adriandlam adriandlam commented Dec 1, 2025 •
edited
Loading

@sveltejs/adapter-vercel uses @vercel/nft which does static analysis at build-time, trying to resolve all string literals i assume.

this made @vercel/nft try and resolve temporary files, ex. /proc introduced in #471

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a49039a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/utils Patch
@workflow/core Patch
@workflow/errors Patch
@workflow/world-local Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
workflow Patch
@workflow/world-postgres Patch
@workflow/world-vercel Patch
@workflow/sveltekit Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Dec 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Comment Dec 1, 2025 7:26pm
example-nextjs-workflow-webpack Ready Ready Preview Comment Dec 1, 2025 7:26pm
example-workflow Ready Ready Preview Comment Dec 1, 2025 7:26pm
workbench-express-workflow Ready Ready Preview Comment Dec 1, 2025 7:26pm
workbench-hono-workflow Ready Ready Preview Comment Dec 1, 2025 7:26pm
workbench-nitro-workflow Ready Ready Preview Comment Dec 1, 2025 7:26pm
workbench-nuxt-workflow Ready Ready Preview Comment Dec 1, 2025 7:26pm
workbench-sveltekit-workflow Ready Ready Preview Comment Dec 1, 2025 7:26pm
workbench-vite-workflow Ready Ready Preview Comment Dec 1, 2025 7:26pm
workflow-docs Ready Ready Preview Comment Dec 1, 2025 7:26pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025 •
edited
Loading

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

World Framework Workflow Time Wall Time Overhead vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.040s (-4.3%) 1.016s (~) 0.976s 1.00x
💻 Local Nitro 0.043s (-6.1% 🟢) 1.006s (~) 0.963s 1.07x
💻 Local Express 0.043s (-2.5%) 1.007s (~) 0.963s 1.08x
🐘 Postgres Next.js (Turbopack) 0.257s (-24.9% 🟢) 1.022s (~) 0.765s 6.37x
🐘 Postgres Nitro 0.399s (+15.9% 🔺) 1.012s (~) 0.613s 9.91x
🐘 Postgres Express 0.450s (+82.9% 🔺) 1.015s (-2.2%) 0.565s 11.16x
▲ Vercel Express 0.617s (+24.3% 🔺) 1.604s (+20.9% 🔺) 0.987s 15.32x
▲ Vercel Next.js (Turbopack) 0.629s (+22.4% 🔺) 1.430s (-10.7% 🟢) 0.801s 15.60x
▲ Vercel Nitro 0.635s (+30.7% 🔺) 1.383s (-5.7% 🟢) 0.748s 15.76x

workflow with 1 step

World Framework Workflow Time Wall Time Overhead vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.107s (+14.9% 🔺) 1.011s (~) 0.904s 1.00x
💻 Local Express 0.111s (~) 1.006s (~) 0.895s 1.04x
💻 Local Nitro 0.112s (+2.5%) 1.005s (~) 0.894s 1.04x
🐘 Postgres Next.js (Turbopack) 0.878s (+11.9% 🔺) 1.015s (~) 0.138s 8.21x
🐘 Postgres Nitro 1.190s (-2.1%) 1.910s (-5.0%) 0.721s 11.13x
🐘 Postgres Express 1.251s (+45.9% 🔺) 2.012s (+66.2% 🔺) 0.761s 11.70x
▲ Vercel Express 1.851s (+24.2% 🔺) 2.774s (+16.2% 🔺) 0.924s 17.31x
▲ Vercel Next.js (Turbopack) 2.113s (+29.8% 🔺) 2.986s (+15.2% 🔺) 0.873s 19.77x
▲ Vercel Nitro 2.143s (+42.9% 🔺) 2.931s (+16.7% 🔺) 0.788s 20.05x

workflow with 10 sequential steps

World Framework Workflow Time Wall Time Overhead vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.650s (~) 1.011s (~) 0.361s 1.00x
💻 Local Express 0.766s (-2.0%) 1.005s (~) 0.239s 1.18x
💻 Local Nitro 0.788s (+3.3%) 1.006s (~) 0.218s 1.21x
🐘 Postgres Nitro 4.804s (-26.5% 🟢) 5.214s (-29.7% 🟢) 0.410s 7.39x
🐘 Postgres Next.js (Turbopack) 5.253s (+1.7%) 6.019s (~) 0.766s 8.08x
🐘 Postgres Express 7.823s (+50.7% 🔺) 8.617s (+48.2% 🔺) 0.794s 12.04x
▲ Vercel Nitro 10.892s (+1.4%) 11.435s (+0.6%) 0.543s 16.76x
▲ Vercel Next.js (Turbopack) 11.157s (+7.1% 🔺) 12.031s (+5.6% 🔺) 0.874s 17.17x
▲ Vercel Express 11.992s (+15.1% 🔺) 12.839s (+13.6% 🔺) 0.847s 18.45x

workflow with 10 parallel steps

World Framework Workflow Time Wall Time Overhead vs Fastest
💻 Local 🥇 Express 0.383s (-5.9% 🟢) 1.005s (~) 0.622s 1.00x
💻 Local Nitro 0.393s (+1.1%) 1.005s (~) 0.612s 1.03x
💻 Local Next.js (Turbopack) 0.414s (+5.8% 🔺) 1.013s (~) 0.598s 1.08x
🐘 Postgres Nitro 0.844s (-29.5% 🟢) 1.611s (-20.1% 🟢) 0.766s 2.20x
🐘 Postgres Next.js (Turbopack) 0.878s (-25.9% 🟢) 1.014s (-44.5% 🟢) 0.136s 2.29x
🐘 Postgres Express 0.996s (-13.9% 🟢) 1.415s (-12.2% 🟢) 0.419s 2.60x
▲ Vercel Next.js (Turbopack) 2.617s (-4.2%) 3.529s (-5.0%) 0.912s 6.82x
▲ Vercel Express 2.676s (-3.0%) 3.617s (+4.5%) 0.942s 6.98x
▲ Vercel Nitro 2.784s (+3.2%) 3.455s (-8.3% 🟢) 0.671s 7.26x

Stream Benchmarks

Stream benchmarks include Time to First Byte (TTFB) metrics.

workflow with stream

World Framework Workflow Time TTFB Wall Time Overhead vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.144s (-4.6%) 1.003s (~) 1.014s (~) 0.869s 1.00x
💻 Local Nitro 0.179s (+1.2%) 0.993s (~) 1.009s (~) 0.830s 1.24x
💻 Local Express 0.188s (+5.7% 🔺) 0.991s (~) 1.008s (~) 0.820s 1.30x
🐘 Postgres Express 0.806s (+10.8% 🔺) 0.860s (+1.8%) 1.010s (~) 0.204s 5.58x
🐘 Postgres Nitro 0.903s (-20.1% 🟢) 1.572s (-9.7% 🟢) 1.611s (-15.8% 🟢) 0.708s 6.25x
🐘 Postgres Next.js (Turbopack) 1.115s (+49.4% 🔺) 1.601s (+98.2% 🔺) 1.716s (+69.0% 🔺) 0.601s 7.72x
▲ Vercel Nitro 2.518s (~) 3.076s (+7.5% 🔺) 3.585s (+8.5% 🔺) 1.067s 17.42x
▲ Vercel Express 2.538s (-1.6%) 2.960s (-7.3% 🟢) 3.724s (+4.9%) 1.187s 17.56x
▲ Vercel Next.js (Turbopack) 2.720s (+4.3%) 3.096s (+3.8%) 3.520s (+2.7%) 0.799s 18.83x

Summary: Fastest Framework by World

Winner determined by most benchmark wins

World 🥇 Fastest Framework Wins
💻 Local Next.js (Turbopack) 4/5
🐘 Postgres Next.js (Turbopack) 2/5
▲ Vercel Express 2/5

Summary: Fastest World by Framework

Winner determined by most benchmark wins

Framework 🥇 Fastest World Wins
Express 💻 Local 5/5
Next.js (Turbopack) 💻 Local 5/5
Nitro 💻 Local 5/5
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world
  • 🐘 Postgres: PostgreSQL database world
  • ▲ Vercel: Vercel production world

@adriandlam adriandlam changed the title fix: build proc paths dynamically fix: @vercel/nft parsing proc file paths in sveltekit adapter Dec 1, 2025
@alex-holovach alex-holovach mentioned this pull request Dec 1, 2025
Merged
@adriandlam adriandlam marked this pull request as ready for review December 1, 2025 19:31
@adriandlam adriandlam merged commit bc9b628 into main Dec 1, 2025
65 of 66 checks passed
@adriandlam adriandlam deleted the fix/sveltekit-port-detection branch December 1, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranaygp pranaygp pranaygp approved these changes

@VaguelySerious VaguelySerious VaguelySerious approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adriandlam @pranaygp @VaguelySerious