From f758aaa8bf5e82b429b2c50541b7e903b7243d92 Mon Sep 17 00:00:00 2001 From: Tamir Date: Mon, 19 May 2025 15:09:35 +0300 Subject: [PATCH 1/2] added func unmount_fileset_secret --- CHANGELOG.md | 4 ++++ datacrunch/containers/containers.py | 12 ++++++++++++ 2 files changed, 16 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7db320d..fac5faa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Added + +- Function to unmount fileset secret from a deployment + ### Changed - This file and CONTRIBUTING.rst to markdown diff --git a/datacrunch/containers/containers.py b/datacrunch/containers/containers.py index de16a91..dccb16e 100644 --- a/datacrunch/containers/containers.py +++ b/datacrunch/containers/containers.py @@ -1008,3 +1008,15 @@ def create_fileset_secret_from_file_paths(self, secret_name: str, file_paths: Li "name": secret_name, "files": processed_files }) + + def unmount_fileset_secret(self, deployment_name: str, secret_name: str) -> None: + """Unmounts a fileset secret from a deployment. + + Args: + deployment_name: Name of the deployment. + secret_name: Name of the secret to unmount. + """ + self.client.delete(FILESET_SECRETS_ENDPOINT, { + "deployment_name": deployment_name, + "secret_name": secret_name, + }) From 7cca16ed5a5bc793f2a65afc02a51b0241906fa2 Mon Sep 17 00:00:00 2001 From: Tamir Date: Mon, 19 May 2025 15:23:12 +0300 Subject: [PATCH 2/2] var rename --- datacrunch/containers/containers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datacrunch/containers/containers.py b/datacrunch/containers/containers.py index dccb16e..a78efb2 100644 --- a/datacrunch/containers/containers.py +++ b/datacrunch/containers/containers.py @@ -1009,7 +1009,7 @@ def create_fileset_secret_from_file_paths(self, secret_name: str, file_paths: Li "files": processed_files }) - def unmount_fileset_secret(self, deployment_name: str, secret_name: str) -> None: + def unmount_fileset_secret(self, deployment_name: str, fileset_secret_name: str) -> None: """Unmounts a fileset secret from a deployment. Args: @@ -1018,5 +1018,5 @@ def unmount_fileset_secret(self, deployment_name: str, secret_name: str) -> None """ self.client.delete(FILESET_SECRETS_ENDPOINT, { "deployment_name": deployment_name, - "secret_name": secret_name, + "fileset_secret_name": fileset_secret_name, })