Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unpublish and add or remove star colision #1434

Merged
merged 3 commits into from Aug 10, 2019

Conversation

@juanpicado
Copy link
Member

commented Aug 10, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue? yes
  • Unit or Functional tests are included in the PR yes

Description:

The issue was the npm star use a similar payload, but we did not check properly the shape of the payload, this fix and allow unpublish correctly.

Improve unit testing for publishing and unpublishing
Add new code documentation for future changes.

Resolves #1359

juanpicado added 3 commits Aug 10, 2019
fix: unpublish and add or remove star colision
The issue was the npm star use a similar payload, but we did not check properly the shape of the payload, this fix and allow unpublish correctly.

Improve unit testing for publishing and unpublishing
Add new code documentation for future changes.
chore: add missing type
this will requires update types in the future

@juanpicado juanpicado merged commit c264f94 into master Aug 10, 2019

3 of 4 checks passed

release:tag-filter release:tag-filter
Details
Docker build health check Docker build health check
Details
Test Publish Verdaccio Test Publish Verdaccio
Details
workflow Workflow: workflow
Details

@juanpicado juanpicado deleted the fix-1359-1 branch Aug 10, 2019

@juanpicado juanpicado modified the milestones: 4.3.0, 4.x.x Aug 10, 2019

@lock

This comment has been minimized.

Copy link

commented Aug 20, 2019

🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed.
We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data and to provide you better feedback 🤝and better visibility 👀.
If you consider, you can attach this ticket 📨 to the new one as a reference for better context.
Thanks for being a part of the Verdaccio community! 💘

@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.