New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #78 Add new setting to allow publish when uplinks are offline #223

Merged
merged 2 commits into from Jul 24, 2017

Conversation

Projects
None yet
1 participant
@juanpicado
Member

juanpicado commented Jun 19, 2017

Type: bug

The following has been addressed in the PR:

  • X There is a related issue
  • Unit or Functional tests are included in the PR (WIP)

Description:

Resolves #78 and rlidwka/sinopia#356

@juanpicado juanpicado requested a review from Meeeeow Jun 19, 2017

@juanpicado juanpicado added the bug label Jun 19, 2017

@codecov

This comment has been minimized.

codecov bot commented Jun 19, 2017

Codecov Report

Merging #223 into master will decrease coverage by 1.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   80.31%   78.58%   -1.73%     
==========================================
  Files          23       19       -4     
  Lines        1341     1046     -295     
==========================================
- Hits         1077      822     -255     
+ Misses        264      224      -40
Impacted Files Coverage Δ
src/lib/search.js
src/lib/plugin-loader.js
src/lib/status-cats.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a58782...672589b. Read the comment docs.

@juanpicado juanpicado referenced this pull request Jun 26, 2017

Closed

Unable to retrieve packages while offline #177

1 of 3 tasks complete

@juanpicado juanpicado force-pushed the fix_78 branch 5 times, most recently from 7890ccb to c4180a5 Jul 9, 2017

@juanpicado juanpicado force-pushed the fix_78 branch 4 times, most recently from 94a409b to 90f0e8b Jul 18, 2017

@juanpicado juanpicado force-pushed the fix_78 branch 16 times, most recently from 18275da to a292906 Jul 21, 2017

juanpicado added some commits Jun 19, 2017

@juanpicado juanpicado force-pushed the fix_78 branch from 8c0070f to 672589b Jul 24, 2017

@juanpicado juanpicado merged commit 90854b2 into master Jul 24, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@juanpicado juanpicado deleted the fix_78 branch Jul 24, 2017

@lock

This comment has been minimized.

lock bot commented May 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.