Refactorized AbstractCompareOperator - is symetric / improved comparison between different types #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrPytelka
changed the title
verhas
reviewed
Feb 4, 2020
| return null; | ||
| } | ||
| return Double.parseDouble(s); | ||
| try { |
PetrPytelka
force-pushed
the
symetric_comparator
branch
2 times, most recently
from
aa9c669 to
9d626bd
Compare
Contributor
Author
|
I simplified implementation of comparators. Each comparator has to implement only one simple method: boolean decide(int comparisonResult). This implementation is also base for adding new data types as LocalDate and EmptyValue. |
…fferent types. Do not prefer left operand over right operand. E.g.: newly 3.0=3 is same as 3=3.0
PetrPytelka
force-pushed
the
symetric_comparator
branch
from
9d626bd to
adb0775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved comparison between different type.
Do not prefer left operand over right operand. E.g.: newly 3.0=3 is same as 3=3.0, same behavioure for string vs numerical value. Improved compatibility with VBA.