Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum constant ranges without colons #1204

Closed
veripoolbot opened this issue Sep 11, 2017 · 4 comments
Closed

Fix enum constant ranges without colons #1204

veripoolbot opened this issue Sep 11, 2017 · 4 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Sep 11, 2017


Author Name: Mike Popoloski
Original Redmine Issue: 1204 from https://www.veripool.org


Commit 17a9b22 fixed cell ranges that are specified without colons (there were one too many in the range). This matches a change we had locally, but unfortunately it looks like the same issue effects enum constants specified with the bracket range syntax. Also even more unfortunately, I don't think the solution of just adding the AstSub into the .y file works here, because that enum generation happens before constants are handled. I have changes locally that make it work but they're a little hacky; let me know if you want me to include the patch.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 11, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-11T23:30:30Z


Can you please send the patch along with a test? Thanks

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 12, 2017


Original Redmine Comment
Author Name: Mike Popoloski
Original Date: 2017-09-12T14:30:19Z


Patch is attached along with a modification to the t_enum test showing the issue.

Like I said, the change is hacky so I wouldn't be surprised if you had a better way of fixing it, but this works for us.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 12, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-12T22:57:02Z


Thanks for the patch, did something similar. Fixed in git towards 3.911.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 23, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-23T14:15:08Z


In 3.912.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.