Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more constants for function parameter default values #1211

Closed
veripoolbot opened this issue Sep 13, 2017 · 2 comments
Closed

Support more constants for function parameter default values #1211

veripoolbot opened this issue Sep 13, 2017 · 2 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Sep 13, 2017


Author Name: Mike Popoloski
Original Redmine Issue: 1211 from https://www.veripool.org

Original Assignee: Mike Popoloski


Functions sort of supported constant default values, but not when assigned from something like a parameter or another function call. I made a minor change that fixes it for our use cases; I'm not sure if it's actually the correct thing to do in all circumstances but it seems like a relatively safe change because any code that will hit it would otherwise not compile anyway.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 13, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-13T23:48:58Z


Another good one, pushed to git towards 3.911.

BTW minor nit if you have more coming "git format-patch" is preferred as your patch format seems to not work perfectly with "git apply".

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 23, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-23T14:14:52Z


In 3.912.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.