Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Makefile seems to have incorrect paths #1220

Closed
veripoolbot opened this issue Sep 23, 2017 · 4 comments
Closed

Example Makefile seems to have incorrect paths #1220

veripoolbot opened this issue Sep 23, 2017 · 4 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Sep 23, 2017


Author Name: Shareef Jalloq
Original Redmine Issue: 1220 from https://www.veripool.org

Original Assignee: Wilson Snyder (@wsnyder)


Hi there,

I've copied the example Makefile, verilator/3.900/share/verilator/examples/test_c/Makefile, to a test bench directory I'm trying to play with. However, when running 'make prep', I see that the tool installation paths must have changed since the Makefile was written.

The Makefile is looking for the /bin and /include directories at the same VERILATOR_ROOT path but they are at different levels of hierarchy. My tree looks like (on MacOS):

% ll /usr/local/Cellar/verilator/3.900/share/verilator/include/
total 760
drwxr-xr-x  27 sjalloq  admin    918 15 Jan  2017 .
drwxr-xr-x   5 sjalloq  admin    170 15 Jan  2017 ..
-rw-r--r--   1 sjalloq  admin  46030 15 Jan  2017 verilated.cpp
-rw-r--r--   1 sjalloq  admin  77154 15 Jan  2017 verilated.h
-rw-r--r--   1 sjalloq  admin   6454 15 Jan  2017 verilated.mk
-rw-r--r--   1 sjalloq  admin   1150 15 Jan  2017 verilated.v
-rw-r--r--   1 sjalloq  admin   1113 15 Jan  2017 verilated_config.h
-rw-r--r--   1 sjalloq  admin   1119 15 Jan  2017 verilated_config.h.in
-rw-r--r--   1 sjalloq  admin  15462 15 Jan  2017 verilated_cov.cpp
-rw-r--r--   1 sjalloq  admin   5282 15 Jan  2017 verilated_cov.h
-rw-r--r--   1 sjalloq  admin   7052 15 Jan  2017 verilated_cov_key.h
-rw-r--r--   1 sjalloq  admin   9877 15 Jan  2017 verilated_dpi.cpp
-rw-r--r--   1 sjalloq  admin   2522 15 Jan  2017 verilated_dpi.h
-rw-r--r--   1 sjalloq  admin   2788 15 Jan  2017 verilated_heavy.h
-rw-r--r--   1 sjalloq  admin   9895 15 Jan  2017 verilated_imp.h
-rw-r--r--   1 sjalloq  admin   7357 15 Jan  2017 verilated_save.cpp
-rw-r--r--   1 sjalloq  admin   8288 15 Jan  2017 verilated_save.h
-rw-r--r--   1 sjalloq  admin   1925 15 Jan  2017 verilated_sc.h
-rw-r--r--   1 sjalloq  admin   3610 15 Jan  2017 verilated_syms.h
-rw-r--r--   1 sjalloq  admin  24606 15 Jan  2017 verilated_vcd_c.cpp
-rw-r--r--   1 sjalloq  admin  17337 15 Jan  2017 verilated_vcd_c.h
-rw-r--r--   1 sjalloq  admin   5945 15 Jan  2017 verilated_vcd_sc.cpp
-rw-r--r--   1 sjalloq  admin   7584 15 Jan  2017 verilated_vcd_sc.h
-rw-r--r--   1 sjalloq  admin  48039 15 Jan  2017 verilated_vpi.cpp
-rw-r--r--   1 sjalloq  admin  18990 15 Jan  2017 verilated_vpi.h
-rw-r--r--   1 sjalloq  admin  11573 15 Jan  2017 verilatedos.h
drwxr-xr-x   4 sjalloq  admin    136 15 Jan  2017 vltstd

% ls -al /usr/local/Cellar/verilator/3.900/bin
total 16440
drwxr-xr-x   8 sjalloq  admin      272 15 Jan  2017 .
drwxr-xr-x  12 sjalloq  admin      408 21 Sep 21:58 ..
-rwxr-xr-x   1 sjalloq  admin   153173 15 Jan  2017 verilator
-rwxr-xr-x   1 sjalloq  admin  4056884 15 Jan  2017 verilator_bin
-rwxr-xr-x   1 sjalloq  admin  4062316 15 Jan  2017 verilator_bin_dbg
-rwxr-xr-x   1 sjalloq  admin     8370 15 Jan  2017 verilator_coverage
-rwxr-xr-x   1 sjalloq  admin   118256 15 Jan  2017 verilator_coverage_bin_dbg
-rwxr-xr-x   1 sjalloq  admin     6487 15 Jan  2017 verilator_profcfunc

Is this just an oversight and can I just soft link to share/verilator/include?

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 23, 2017


Original Redmine Comment
Author Name: Shareef Jalloq
Original Date: 2017-09-23T10:12:32Z


Hmmm, and there are two bin/ directories too:

% ll /usr/local/Cellar/verilator/3.900/share/verilator/bin/
total 8
drwxr-xr-x  3 sjalloq  admin  102 15 Jan  2017 .
drwxr-xr-x  5 sjalloq  admin  170 15 Jan  2017 ..
-rwxr-xr-x  1 sjalloq  admin  697 15 Jan  2017 verilator_includer

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 23, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-23T14:02:26Z


When I use "./configure --prefix /foo ; make ; make install" I properly get:

/foo/bin/verilator
/foo/bin/verilator_bin
/foo/bin/verilator_bin_dbg
/foo/bin/verilator_coverage
/foo/bin/verilator_coverage_bin_dbg
/foo/bin/verilator_profcfunc
/foo/share/man/man1/verilator.1
/foo/share/man/man1/verilator_coverage.1
/foo/share/man/man1/verilator_profcfunc.1
/foo/share/pkgconfig/verilator.pc
/foo/share/verilator/bin/verilator_includer
/foo/share/verilator/examples/...
/foo/share/verilator/include/...

However I agree that the examples aren't running right when copied. I'll fix that. Meanwhile I'd suggest following the example in the manual instead.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Sep 24, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-09-24T01:34:20Z


I redid all the examples in git, they are replaced by a new examples/ directory. Please give it a try.

Fixed in git towards 3.913.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Oct 14, 2017


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-10-14T20:22:59Z


In 3.914.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.