Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend UNUSED to flag signals which are not in the cone of a module output #1395

Open
veripoolbot opened this issue Feb 1, 2019 · 2 comments
Open

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Feb 1, 2019


Author Name: Geoff Barrett
Original Redmine Issue: 1395 from https://www.veripool.org


The following code produces no warnings:

module unused_vars (
  input var logic ck,
  output var logic c
);

logic d, q;

always_ff @(posedge ck) q <= d;
always_comb d = q;

always_comb c = '0;

endmodule : unused_vars

The combination of UNUSED and UNOPTFLAT means (I think) that we will always get a warning if signals are not either in the cone of an output or a nonblocking assignment. However, d and q are only used by each other and can be eliminated from the module and it would be very useful to get a warning about this.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Feb 7, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-02-07T01:00:38Z


Agreed this is useful and the base info is in the structures, but can't get to it soon.

@geoffbarrett62

This comment has been minimized.

Copy link

@geoffbarrett62 geoffbarrett62 commented Dec 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.