Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++17, removed afterwards #1421

Closed
veripoolbot opened this issue Apr 29, 2019 · 4 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Apr 29, 2019


Author Name: Pieter Kapsenberg
Original Redmine Issue: 1421 from https://www.veripool.org

Original Assignee: Auto Update Daemon (@veripool-bot)


https://en.cppreference.com/w/cpp/keyword/register

Line 251:

https://en.cppreference.com/w/cpp/keyword/register
</code>

Fix is to just remove the specifier. Currently compiling with warnings on will expose this (Clang-7 at least).

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Apr 29, 2019


Original Redmine Comment
Author Name: Pieter Kapsenberg
Original Date: 2019-04-29T07:54:13Z


Woops - line 251:

static unsigned LZ4_NbCommonBytes (register size_t val)
</code>
@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Apr 29, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-04-29T09:34:22Z


Pushed to git towards 4.013.

Note this file comes from GTKwave sources. I've emailed Tony Bybell to fix it, it would save a step next time to please ask GTKWave directly to fix it, then ask Verilator to pull the fix.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Apr 29, 2019


Original Redmine Comment
Author Name: Pieter Kapsenberg
Original Date: 2019-04-29T09:35:58Z


Thanks Wilson. Will do for next time.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented May 9, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-05-09T01:38:06Z


In 4.014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.