Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPI hierarchy naming #1422

Closed
veripoolbot opened this issue Apr 29, 2019 · 3 comments
Closed

VPI hierarchy naming #1422

veripoolbot opened this issue Apr 29, 2019 · 3 comments
Assignees

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Apr 29, 2019


Author Name: Stefan Wallentowitz (@wallento)
Original Redmine Issue: 1422 from https://www.veripool.org

Original Assignee: Wilson Snyder (@wsnyder)


Hi,

I am currently looking into coupling cocotb and Verilator and stumbled over one major issue, that can be solved in a couple of ways. I am wondering what you think about it and suggest as most acceptable solution.

Everything that has public access currently becomes accessible by its scope. But the naming at runtime always involves the toplevel wrapper name (TOP by default), while cocotb operates on the full names in the actual verilog hierarchy. So, there are a couple of options:

  1. Push it to cocotb and prepend the top name. This is not overly complex, but a bit cumbersome.

  2. Change the hierarchy naming in Verilator entirely. This is a mess as it will break a lot of existing code.

  3. Follow Verilog hierarchy naming in VPI. This seems to be the right place and has the least impact.

So, my proposal is to implement 3. I can do it as part of my effort and send as the first patch.

What do you think?

Cheers,
Stefan

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Apr 29, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-04-29T09:36:51Z


I agree 3 makes the most sense. Perhaps the TOP should also be suppressed in %m messages, that is it will look to run time as if TOP doesn't exist for VPI and output messages.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jun 22, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-22T21:04:36Z


Stumbled into some other code related to handling TOP, note the existing code allows passing "" when constructing a model and the "TOP" prefix (from the user's model instantiation) will no longer appear in %m messages.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jun 29, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-29T10:16:29Z


See last msg, think this will make naming compatible, if not please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.