Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to silence the command-failed message #1436

Closed
veripoolbot opened this issue May 13, 2019 · 4 comments
Closed

Add an option to silence the command-failed message #1436

veripoolbot opened this issue May 13, 2019 · 4 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented May 13, 2019


Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 1436 from https://www.veripool.org

Original Assignee: Todd Strader (@toddstrader)


Often times my command line invocation of Verilator is so large that this pushes the actual error message off the screen. Also, I'm happy to let my build system tell me what it was doing instead of asking Verilator to self-report. In any case, nothing is affected without the switch. Additionally, I tried to replicate the error codes from die(), so if someone is depending on specific return codes for some reason things should still work.
https://github.com/toddstrader/verilator-dev/tree/quiet_error

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented May 13, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-05-13T22:36:51Z


Seems reasonable. Please two things then will merge, 1. need documentation for flag (you did summary but not the larger per-flag descriptions), and 2. call the test t_flag_quiet_exit so more obvious what is being tested; perhaps the test can just pass a bad filename as which error is generated doesn't really matter.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented May 14, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-05-14T09:40:24Z


Updated at:
https://github.com/toddstrader/verilator-dev/tree/quiet_error

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented May 14, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-05-14T10:51:37Z


Thanks for updating. Pushed to git towards 4.016.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 16, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-16T13:58:18Z


In 4.016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.