Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
-Wsign-compare warning in verilated.cpp #1437
Original Assignee: Sergey Kvachonok (@ravenexp)
I do not use verilated.mk to compile the generated C++ code, and I get these warnings (CFLAGS = -Wall -Wextra)
I've modified VL_WRITEMEM_N() to use unsigned size and offset integer types throughout and moved the address range checks out of the writing loop.
now aborts with an error message instead of creating an empty dump file.
I tested the attached patch with 'make test_regress' only, as I don't use $writemem() myself.