Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sameHash error on type parameters after 4.014 #1456

Closed
veripoolbot opened this issue Jun 4, 2019 · 10 comments
Closed

sameHash error on type parameters after 4.014 #1456

veripoolbot opened this issue Jun 4, 2019 · 10 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Jun 4, 2019


Author Name: Stefan Wallentowitz (@wallento)
Original Redmine Issue: 1456 from https://www.veripool.org


Hi,

when building the ariane core (https://github.com/pulp-platform/ariane) with the current master, I get the following internal error:

%Error: Internal Error: /data/ariane/src/load_store_unit.sv:211: ../V3Hashed.cpp:70: sameHash function undefined (returns 0) for node under CFunc.
... See the manual and http://www.veripool.org/verilator for more assistance.

I can try to bisect or look into candidates later this month. It works with 4.014

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 4, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-06-04T20:11:13Z


Ugh, smells like this guy:
https://www.veripool.org/issues/1427-Verilator-Incorrect-real-parameter-assignment

I probably still have this swapped in. I'll pull the Ariane repo and see what I can find.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 5, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-06-05T00:35:17Z


Looks like I broke something with parameter types:
https://github.com/toddstrader/verilator-dev/tree/samehash-fix

I'll work on a fix.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 5, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-06-05T10:48:56Z


This fixes the Ariane build, but my new test still has issues:
https://github.com/toddstrader/verilator-dev/tree/bug_escapes_to_cpp

It's possible that those issues predate my #1427 fix. I'm still investigating.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 6, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-06-06T00:27:29Z


I re-ran the test suite with this fix and everything passes. I also rewound to just before the #1427 fix and tried out my new test. It's breaks in the same way that it does with my latest fix. So there are two things going on here:

  1. I broke type parameters (under certain circumstances) with my #1427 fix. That should be resolved now.
  2. Dotted references to type parameters don't seem to work correctly. See the commented out portions of my new test. I'm always getting $bits() == 32. Which is interesting because that's not the default type size. I guess it just returns the size of an int or something.

Wilson, what do you want to do here? Do you want to land this in two parts? If so, #1 should be ready here:
https://github.com/toddstrader/verilator-dev/tree/samehash-fix
And if we're landing in two parts I'll open another issue. I'd prefer this, because fixing #2 isn't at the top of my list right now.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 6, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-06T00:46:48Z


Todd, great patch, thanks. Merged that, please file another bug if you can't look at #2, as I can't look immediately either.

Pushed to git towards 4.015.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 6, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-06-06T02:42:56Z


Sorry, one more update to the same branch:
https://github.com/toddstrader/verilator-dev/tree/samehash-fix

It dawned on me that this test should have a --debug-collision variant.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 6, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-06T09:48:39Z


Suspect you forgot to push samehash-fix.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 6, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-06-06T13:40:57Z


Sorry, what do you think is missing? This commit hash the additional --debug-collision test:
toddstrader/verilator-dev@1c99e6f

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 6, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-06T23:57:49Z


Pushed, thanks.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jun 16, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-16T13:59:22Z


In 4.016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.