Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fstapi.c compile errors. #1460

Closed
veripoolbot opened this issue Jun 11, 2019 · 4 comments
Closed

fstapi.c compile errors. #1460

veripoolbot opened this issue Jun 11, 2019 · 4 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Jun 11, 2019


Author Name: Richard Myers
Original Redmine Issue: 1460 from https://www.veripool.org

Original Assignee: Richard Myers


Hi,

I get many errors like the following with Verilator 4.014 (and before) when compiling fstapi using mingw32 (under Linux):

verilator-4.014/include/gtkwave/fstapi.c:2752:46: error: expected ')' before 'PRIu32'
elem_count_len = sprintf(elem_count_buf, "%" PRIu32, elem_count);
~ ^~~~~~~
)
...

I've attached a patch file against verilatedos.h that fixes the problem in my environment (Fedora 29, mingw32-gcc-c++-8.3.0-2.fc29.x86_6).

Thanks!
Richard

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jun 11, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-11T22:52:12Z


Thanks for debugging.

_WORDSIZE is defined in sys/types.h and your patch moves the test above this include, so I think this is likely to break for other compilers. Perhaps the VL_PRI64 needs to remain where it was, and only the USE_MINW_ANSI_STDIO and STDC_FORMAT_MACROS move up?

Also, just one time, please either edit the (new) docs/CONTRIBUTORS file to add your name and put that in the patch, or just post "I certify my contribution as described in https://developercertificate.org", to certify your contribution. Thanks.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jun 12, 2019


Original Redmine Comment
Author Name: Richard Myers
Original Date: 2019-06-12T00:47:05Z


Hi,

Yes, did it. Here's the new and improved patch that hopefully has a minimal effect on everyone else. I added my name. I'm already in the verilator.pdf doc file from back in the day (circa 2003...)

Thanks!
Richard

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jun 12, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-12T01:38:22Z


Looks good, thanks for the efforts.

Pushed to git towards 4.015.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Jun 16, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-06-16T13:59:34Z


In 4.016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.