Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rr support to the perl wrappers #1481

Closed
veripoolbot opened this issue Jul 25, 2019 · 5 comments
Closed

Add rr support to the perl wrappers #1481

veripoolbot opened this issue Jul 25, 2019 · 5 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Jul 25, 2019


Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 1481 from https://www.veripool.org

Original Assignee: Todd Strader (@toddstrader)


As discussed in the forums:
https://www.veripool.org/boards/3/topics/3028

This allows users to record verilation with rr with verilator and driver.pl. Also driver.pl can record the sim with rr.

Proposed patch is here:
https://github.com/toddstrader/verilator-dev/tree/rr-support

CI is green so at least I didn't break anything. And I confirmed that "verilator -rr", "driver.pl --rr" and "driver.pl --rrsim" all work on my system.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jul 25, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-07-25T23:45:56Z


          "gdb!"        => \$opt_gdb,
+          "rr!"         => \$opt_rr,
           "gdbbt!"      => \$opt_gdbbt,

Please keep switches sorted (more or less).

Please also update Changes to mention the new --rr.

With those you can squash and push to trunk.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jul 26, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-07-26T09:22:50Z


Squashed, pushed and green.

Can you explain the number of stars for each entry in Changes? It appears that they are usually (but not always) monotonically decreasing between releases. I hope I did the right thing.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jul 26, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-07-26T10:23:05Z


Number of stars is the importance. Usually big things 2, features are 3, bug fixes 4, but not a science.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Jul 26, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-07-26T10:24:59Z


Also, please add the bug # to the Changes, did this, e.g.

 ***   Add --rr, #�. [Todd Strader]

Thanks for the work.

@veripoolbot
Copy link
Contributor Author

@veripoolbot veripoolbot commented Aug 29, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-08-29T23:14:17Z


In 4.018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.