Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dpi-hdr-only option #1491

Closed
veripoolbot opened this issue Aug 23, 2019 · 5 comments
Closed

Add --dpi-hdr-only option #1491

veripoolbot opened this issue Aug 23, 2019 · 5 comments

Comments

@veripoolbot
Copy link

@veripoolbot veripoolbot commented Aug 23, 2019


Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 1491 from https://www.veripool.org

Original Assignee: Todd Strader (@toddstrader)


Towards #�. I have the feature coded, but am not sure about the best way to test this:
https://github.com/toddstrader/verilator-dev/tree/dpi-header

Ideally, I'd like to run something like t_dpi_import with and without --dpi-hdr-only (to two different output directories). Then I'd check to make sure that with the flag, the DPI header is the only thing that comes out and make sure it is the same as the file produced without the flag. I'm not sure if driver.pl will support something like this. I need to do some reading to figure that out, but if there are other suggestions for testing I'm all ears.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Aug 23, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-08-23T22:31:15Z


It looks like I can just call compile() twice with different flags. I should be able to make something happen when I can get back to this.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Aug 24, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-08-24T12:12:03Z


I added a test for the new option. I believe this is ready to land now:
https://github.com/toddstrader/verilator-dev/tree/dpi-header

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Aug 27, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-08-27T23:02:00Z


I'm fine with your squashing and pushing this.

However in the larger picture (perhaps worth discussing in the other bug) I'd prefer we not need to run the generation of the dpi headers as a separate step.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Aug 28, 2019


Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-08-28T01:44:32Z


Pushed since I've used a similar feature in ModelSim for purposes other than what we're discussing in #�.

@veripoolbot

This comment has been minimized.

Copy link
Author

@veripoolbot veripoolbot commented Aug 29, 2019


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-08-29T23:14:53Z


In 4.018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.